Skip to content

Bug snow mass err#248

Merged
jmccreight merged 25 commits intoDOI-USGS:developfrom
jmccreight:bug_snow_mass_err
Nov 6, 2023
Merged

Bug snow mass err#248
jmccreight merged 25 commits intoDOI-USGS:developfrom
jmccreight:bug_snow_mass_err

Conversation

@jmccreight
Copy link
Copy Markdown
Collaborator

@jmccreight jmccreight commented Oct 28, 2023 •
edited
Loading

  • Closes 'PRMSSoilzone' object has no attribute '_adjust_parameters' #249
  • Ensures mass balance for snow on CONUS introducing new (rare) coditions for through_rain when rain but not snow on a snowpack is subsequently evaporated off during the time step. some of this work updates PRMS code slightly
  • Removed machine epsilons in favor of slightly larger thesholds which are identical in python and fortran
  • Went over consistency of thresholds between PRMS and PWS
  • Introduces a more rare mass balance error (4 times*locations) in 2 years

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #248 (8056e39) into develop (5456603) will increase coverage by 0.61%.
The diff coverage is 90.90%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #248      +/-   ##
===========================================
+ Coverage    78.31%   78.93%   +0.61%     
===========================================
  Files           51       51              
  Lines         6706     6694      -12     
===========================================
+ Hits          5252     5284      +32     
+ Misses        1454     1410      -44
Files Coverage Δ
pywatershed/atmosphere/prms_atmosphere.py 89.87% <100.00%> (ø)
pywatershed/atmosphere/prms_solar_geometry.py 91.97% <100.00%> (+0.26%) ⬆️
pywatershed/constants.py 98.36% <100.00%> (+0.08%) ⬆️
pywatershed/hydrology/prms_canopy.py 80.62% <100.00%> (-0.21%) ⬇️
pywatershed/hydrology/prms_channel.py 93.30% <ø> (ø)
pywatershed/hydrology/prms_soilzone.py 80.82% <100.00%> (+0.10%) ⬆️
pywatershed/hydrology/prms_runoff.py 82.97% <75.00%> (+0.42%) ⬆️
pywatershed/hydrology/prms_snow.py 88.11% <89.65%> (+6.92%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

James McCreight and others added 19 commits October 31, 2023 09:41
update binary on linux
68b670e
@jmccreight
update windows binary
56da8a1
@jmccreight
Merge remote-tracking branch 'upstream/develop' into bug_snow_mass_err
03981a8
@jmccreight
binary again on windows and revise tolerances for win and linux
55c116e
@jmccreight
use existing prms code to reset freeh2o and pk_ice when pkwatere_equi…
f32017d 
…v is <= DNEARZERO
@jmccreight
Merge remote-tracking branch 'jmccreight/bug_snow_mass_err' into bug_…
1b6a285 
…snow_mass_err
@jmccreight
update windows binary again
dc171ca
update linux binary, again
8baf75a
@jmccreight
fix machine epsilons to be identical in python and fortran using slig…
32daedf 
…htly larger than informal definitions
@jmccreight
Merge remote-tracking branch 'jmccreight/bug_snow_mass_err' into bug_…
b9eeec3 
…snow_mass_err
@jmccreight
update windows binary, again again
a70dbb0
Merge remote-tracking branch 'jmccreight/bug_snow_mass_err' into bug_…
1c21e32 
…snow_mass_err
update linux binary again
b9859c1
@jmccreight
update test_prms_canopy tolerance
7fe4a32
@jmccreight
Merge remote-tracking branch 'jmccreight/bug_snow_mass_err' into bug_…
8610016 
…snow_mass_err
@jmccreight
threshold fro through rain to epsilon64 as in prms water balance; cle…
fe4d08d 
…an up and add some missing but currently uused functionality in prms_snow init
@jmccreight
remove small, likely untriggered bug in PRMS5.2.1 and update binary
451b57a
@jmccreight
review closezero, nearzero, and dnearzero and add to pws constants fo…
122fec5 
…r consistency
@jmccreight
lint
8056e39
@jmccreight jmccreight merged commit cdf1a91 into DOI-USGS:develop Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'PRMSSoilzone' object has no attribute '_adjust_parameters'

2 participants

@jmccreight @codecov-commenter